Correctly add the https agent to axios (#1154)

vpulim · Aug 20, 2021 · 65c5eec · 65c5eec
1 parent 94fada0
commit 65c5eec
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/security/ClientSSLSecurity.ts b/src/security/ClientSSLSecurity.ts
@@ -82,6 +82,6 @@ export class ClientSSLSecurity implements ISecurity {
       httpsAgent = new https.Agent(options);
     }
 
-    options.agent = httpsAgent;
+    options.httpsAgent = httpsAgent;
   }
 }
diff --git a/src/security/ClientSSLSecurityPFX.ts b/src/security/ClientSSLSecurityPFX.ts
@@ -51,6 +51,6 @@ export class ClientSSLSecurityPFX implements ISecurity {
       options.passphrase = this.passphrase;
     }
     _.merge(options, this.defaults);
-    options.agent = new https.Agent(options);
+    options.httpsAgent = new https.Agent(options);
   }
 }
diff --git a/test/security/ClientSSLSecurity.js b/test/security/ClientSSLSecurity.js
@@ -101,7 +101,7 @@ describe('ClientSSLSecurity', function() {
       instance.addOptions(firstOptions);
       instance.addOptions(secondOptions);
 
-      firstOptions.agent.should.not.equal(secondOptions.agent);
+      firstOptions.httpsAgent.should.not.equal(secondOptions.httpsAgent);
     });
 
     it('should return the same agent if parameter is present', function () {
@@ -112,7 +112,7 @@ describe('ClientSSLSecurity', function() {
       instance.addOptions(firstOptions);
       instance.addOptions(secondOptions);
 
-      firstOptions.agent.should.equal(secondOptions.agent);
+      firstOptions.httpsAgent.should.equal(secondOptions.httpsAgent);
     });
 
     it('should return the same agent if set in defaults', function () {
@@ -123,7 +123,7 @@ describe('ClientSSLSecurity', function() {
       instance.addOptions(firstOptions);
       instance.addOptions(secondOptions);
 
-      firstOptions.agent.should.equal(secondOptions.agent);
+      firstOptions.httpsAgent.should.equal(secondOptions.httpsAgent);
     });
   });
 });