fix error when soapaction header is not set (#1171)

* fix error when soapaction is not set * fix error when soapaction is not set * + add test for calling the server method without the SOAPAction header set
vpulim · Nov 10, 2021 · d284fea · d284fea
1 parent f6a0979
commit d284fea
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/server.ts b/src/server.ts
@@ -284,6 +284,9 @@ export class Server extends EventEmitter {
   }
 
   private _getSoapAction(req: Request) {
+    if (typeof req.headers.soapaction === 'undefined') {
+         return;
+     }
     const soapAction: string = req.headers.soapaction as string;
     return (soapAction.indexOf('"') === 0)
          ? soapAction.slice(1, -1)

diff --git a/test/server-test.js b/test/server-test.js
@@ -288,7 +288,6 @@ describe('SOAP Server', function () {
     });
   });
 
-
   it('should return correct async results (double argument callback style)', function (done) {
     soap.createClient(test.baseUrl + '/stockquote?wsdl', function (err, client) {
       assert.ifError(err);
@@ -300,6 +299,19 @@ describe('SOAP Server', function () {
     });
   });
 
+  it('should return correct result when called without SOAPAction header', function(done) {
+    soap.createClient(test.baseUrl + '/stockquote?wsdl', function (err, client) {
+      assert.ifError(err);
+      // this clears the SOAPAction header
+      client.addHttpHeader('SOAPAction', '');
+      client.IsValidPrice({ price: 50000 }, function (err, result) {
+        assert.ifError(err);
+        assert.equal(true, !!(result.valid));
+        done();
+      });
+    });
+  });
+
   it('should support Promise return result', function (done) {
     soap.createClient(test.baseUrl + '/stockquote?wsdl', function (err, client) {
       assert.ifError(err);