Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rsa-sha256 support for WSSecurityCert #1052

Merged
merged 8 commits into from Mar 25, 2019
Merged

add rsa-sha256 support for WSSecurityCert #1052

merged 8 commits into from Mar 25, 2019

Conversation

nvbach91
Copy link
Contributor

@nvbach91 nvbach91 commented Mar 24, 2019 •
edited

Looks like the only supported encryption currently supported is rsa-sha1 (default in xml-crypto)
http://www.w3.org/2000/09/xmldsig#rsa-sha1

Added option to specify rsa-sha256
http://www.w3.org/2001/04/xmldsig-more#rsa-sha256

@coveralls
Copy link

coveralls commented Mar 24, 2019 •
edited

Coverage Status

Coverage increased (+0.008%) to 93.223% when pulling 69cd0cd on nvbach91:master into 25440ee on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented Mar 25, 2019

I'll merge once the build is fixed

@nvbach91
Copy link
Contributor Author

nvbach91 commented Mar 25, 2019 •
edited

Hi @jsdevel, I tried to debug fix the build but I got lost in the code. The builg log shows
Unhandled rejection AssertionError: undefined deepEqual { return: '-1', bstrError: '' } but I have no idea why it happened. Could you please have a quick look and point out where exactly is the error? I can then fix it myself. Thanks a lot

@nvbach91
Copy link
Contributor Author

nvbach91 commented Mar 25, 2019 •
edited

@jsdevel nevermind, the build is fixed.

@jsdevel jsdevel merged commit 58c0b8a into vpulim:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nvbach91 @coveralls @jsdevel