Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rsa-sha256 support for WSSecurityCert #1052

Merged
merged 8 commits into from Mar 25, 2019
Merged

add rsa-sha256 support for WSSecurityCert #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d662872
add rsa-sha256 support for WSSecurityCert
nvbach91 Mar 24, 2019
8f59e8d
opt
nvbach91 Mar 24, 2019
0a00887
opt out
nvbach91 Mar 24, 2019
dabadfc
opt in
nvbach91 Mar 24, 2019
ca16c09
added test
nvbach91 Mar 24, 2019
b8cde89
better test label
nvbach91 Mar 24, 2019
0736196
fixing build errors
nvbach91 Mar 24, 2019
69cd0cd
fixed lint
nvbach91 Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/security/WSSecurityCert.ts
View file
Open in desktop
Expand Up @@ -34,6 +34,7 @@ const oasisBaseUri = 'http://docs.oasis-open.org/wss/2004/01';
export interface IWSSecurityCertOptions {
hasTimeStamp?: boolean;
signatureTransformations?: string[];
signatureAlgorithm?: string;
}

export class WSSecurityCert implements ISecurity {
Expand All @@ -53,6 +54,14 @@ export class WSSecurityCert implements ISecurity {
.replace(/(\r\n|\n|\r)/gm, '');

this.signer = new SignedXml();
if (options.signatureAlgorithm === 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha256') {
this.signer.signatureAlgorithm = options.signatureAlgorithm;
this.signer.addReference(
'//*[name(.)="soap:Body"]',
['http://www.w3.org/2001/10/xml-exc-c14n#'],
'http://www.w3.org/2001/04/xmlenc#sha256',
);
}
this.signer.signingKey = {
key: privatePEM,
passphrase: password,
Expand Down
6 changes: 6 additions & 0 deletions test/security/WSSecurityCert.js
View file
Open in desktop
Expand Up @@ -109,4 +109,10 @@ describe('WSSecurityCert', function() {
xml.should.not.containEql('<Created>' + instance.created);
xml.should.not.containEql('<Expires>' + instance.expires);
});

it('should use rsa-sha256 signature method when the signatureAlgorithm option is set to WSSecurityCert', function() {
var instance = new WSSecurityCert(key, cert, '', { hasTimeStamp: false, signatureAlgorithm: 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha256' });
var xml = instance.postProcess('<soap:Header></soap:Header><soap:Body><Body></Body></soap:Body>', 'soap');
xml.should.containEql('SignatureMethod Algorithm="http://www.w3.org/2001/04/xmldsig-more#rsa-sha256"');
});
});