Moved the EJS templates to strings #1036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the EJS templates to strings so they coudl be imported as modules Reason, is having a issue with this in AWS Lambda, where all dependencies are compiled into one file. Fix lint errors in: - lib/wsdl.js - test/request-response-samples/Dummy__should_handle_inline_types/wsdl_options.js New line added to end of Package.json
|
Please merge this. I cannot bundle my service due to this issue. |
|
ejs templates are no longer in the master branch. This was resolved in #1046 |
|
thanks @andygreenegrass ! closing this issue. and thank you @LorneCurrie for originally addressing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the EJS templates to strings so they coudl be imported as modules
Reason, is having a issue with this in AWS Lambda, where all
dependencies are compiled into one file.
Fix lint errors in:
New line added to end of Package.json