Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: send response to client with res.end() #1043

Merged
merged 1 commit into from Feb 11, 2019

Commits on Feb 8, 2019

  1. server: add option enableChunkedEncoding

    Using res.end() to write result instead of res.write() followed by
    res.end() will cause node not to use chunked encoding and include
    Content-Length header. (See nodejs/node#26005) This small distinction is
    important with some client. For example, Windows 10's MDM enrollment
    system will not accept chunked response
    (https://docs.microsoft.com/en-us/windows/client-management/mdm/on-premise-authentication-device-enrollment).
    
    This might improve compatibility with some other clients, too. However,
    there's a small chance that some client may expect the response to be
    chunked. So, I put this behind an option which defaults to enabled and
    can be disabled if needed.
    peat-psuwit committed Feb 8, 2019
    Copy the full SHA
    20390f2 View commit details
    Browse the repository at this point in the history