Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compliance): updated the npm packages #1048

Merged
merged 1 commit into from Mar 11, 2019

Conversation

RishikeshDarandale
Copy link
Contributor

@RishikeshDarandale RishikeshDarandale commented Feb 21, 2019

Updated the outdated npm packages. All the tests are running with success.

Updated the outdated npm packages.

Only following dev dependencies are pending to update

Package          Current  Wanted  Latest  Location
readable-stream    2.0.6   2.0.6   3.1.1  soap
sinon             1.17.7  1.17.7   7.2.4  soap

@coveralls
Copy link

coveralls commented Feb 21, 2019

Coverage Status

Coverage decreased (-0.5%) to 93.216% when pulling 34399f5 on RishikeshDarandale:topics/npm-upgrade into 8d5f15a on vpulim:master.

@RishikeshDarandale
Copy link
Contributor Author

@jsdevel coveralls is failed on for node7 due to timeout, I think it will be increased as per #1047.

Lets enable dependabot for dependency management.

@RishikeshDarandale RishikeshDarandale force-pushed the topics/npm-upgrade branch 2 times, most recently from f4dd3bf to b3ed4c1 Compare February 25, 2019 05:49
@RishikeshDarandale
Copy link
Contributor Author

@jsdevel , I have rebased this PR, but looks like I need to write more test cases of uncovered lines to pass 94%. Though I have not modified any code here! 🤞

test/wsdl-test.js Show resolved Hide resolved
Updated the outdated npm packages.

Only following dev dependencies are pending to update

```console
Package          Current  Wanted  Latest  Location
readable-stream    2.0.6   2.0.6   3.1.1  soap
sinon             1.17.7  1.17.7   7.2.4  soap
```
@jsdevel
Copy link
Collaborator

jsdevel commented Mar 11, 2019

thanks @RishikeshDarandale !

@jsdevel jsdevel merged commit 25440ee into vpulim:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants