Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed MTOM removing soap12header #1084

Merged
merged 2 commits into from Aug 5, 2019
Merged

fixed MTOM removing soap12header #1084

merged 2 commits into from Aug 5, 2019

Conversation

g-m-a
Copy link
Contributor

@g-m-a g-m-a commented Jul 24, 2019

The attachment option added via #1054
was stripping the SOAP 1.2 action header added with forceSoap12Headers

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.301% when pulling f5c2622 on g-m-a:master into 48d0e01 on vpulim:master.

@coveralls
Copy link

coveralls commented Jul 24, 2019

Coverage Status

Coverage increased (+0.02%) to 94.476% when pulling c61512b on g-m-a:master into 48d0e01 on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented Jul 24, 2019

please fix the build and write tests

@g-m-a g-m-a closed this Jul 29, 2019
@g-m-a g-m-a reopened this Aug 5, 2019
@jsdevel jsdevel merged commit 5af5fab into vpulim:master Aug 5, 2019
@jsdevel
Copy link
Collaborator

jsdevel commented Aug 5, 2019

thanks!

@g-m-a
Copy link
Contributor Author

g-m-a commented Aug 5, 2019

Thank you for this module and for approving the pull request!
I'll need to add one more though! :)

Danail-Irinkov pushed a commit to Danail-Irinkov/node-soap that referenced this pull request Jan 19, 2020
* fixed MTOM removing soap12header

* cleaned code + added test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants