Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed preserveWhitespace not taken in account if text contains only spaces #1112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DeadEye0112
Copy link

The preserveWhitespace option is not taken in account if the text only contains spaces. This leads to cases where the returned text should be ' ' but leads to ''.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.855% when pulling 0ea7387 on Agence-Fractale:master into 699b984 on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented Jul 15, 2020

@DeadEye0112 i apologize for the late response. it appears that this change is breaking some of the tests. is it possible to invert the flag to preserve the old default behavior? i.e. instead of preserveWhitespace, maybe discardWhitespace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants