Changes to support the redefining of a namespace alias within different elements. #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lah8789
force-pushed
the
namespace-redefined-in-element
branch
from
6211ef5
to
22c8c88
Compare
within different elements. The provided WSDL was not serializing the response correctly when returning the XML. Created a request response folder to test the changes that were made and made sure code coverage remained the same.
lah8789
force-pushed
the
namespace-redefined-in-element
branch
from
dedd6dc
to
3c88c5e
Compare
|
@jsdevel I have reverted back changes to tests and only have the original changes related to the PR |
lah8789
force-pushed
the
namespace-redefined-in-element
branch
from
3c88c5e
to
cfb4497
Compare
|
@jsdevel , have you had a chance to look at this? |
jsdevel
approved these changes
Oct 1, 2021
|
@lah8789 please pull the latest from master so the PR check can run |
…espace-redefined-in-element
|
@lah8789 please ensure all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided WSDL was not serializing the response correctly when returning the XML.
Created a request response folder to test the changes that were made and made sure code coverage remained the same.
Commented out any test referencing json_response.wsdl because it was failing after I cloned master and ran the tests.