Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid multipart/related Content-Type #1198

Merged
merged 4 commits into from May 1, 2024

Conversation

sandrozbinden-axa
Copy link
Contributor

@sandrozbinden-axa sandrozbinden-axa commented Oct 6, 2022

According to rfc 2384 (https://www.ietf.org/rfc/rfc2387.txt) the multipart/related Content-Type syntax allows only one typefield

The change with pr (#1173) changed the correct start-info field to type. This causes strict soap servers to reject the request because the type is now duplicated and with different values.

This small pr reverts the change to start-info

@sandrozbinden-axa sandrozbinden-axa changed the title fix: change invalid multipart/related Content-Type fix: invalid multipart/related Content-Type Oct 27, 2022
@sandrozbinden-axa
Copy link
Contributor Author

sandrozbinden-axa commented Nov 22, 2022

@jsdevel Do you have time to review this issue? It is preventing us from updating to the latest node-soap version

@sandrozbinden-axa
Copy link
Contributor Author

@benasher44 Do you have time to review this issue? It is preventing us from updating to the latest node-soap version and shouldn't take too much time to review.

@benasher44
Copy link
Contributor

Hi! I have no merge privileges in this repo, unfortunately

@sandrozbinden-axa
Copy link
Contributor Author

Hi @benasher44. Thanks a lot for your quick reply. Do you know anyone with merge privileges? I wasn't really successful with contacting any of the Maintainers listed in the README.

@benasher44
Copy link
Contributor

I dont, sorry! I would recommend using something like patch-package or yarn patch, if you're on yarn 2+ to unblock your local project with this change, for the time being.

@sandrozbinden-axa
Copy link
Contributor Author

Hi @w666

I noticed you've been actively merging PRs lately. Could you please review this one? It's a small fix to ensure compliance with RFC 2384.

@benasher44
Copy link
Contributor

Also would it be possible to reopen the issues tab? I think closing all issues and declaring issue bankruptcy would be preferable to just blocking all issues

@w666
Copy link
Collaborator

w666 commented May 1, 2024

Hi @sandrozbinden-axa, when do you need this change?

@sandrozbinden-axa
Copy link
Contributor Author

Hello @w666,

We are currently using a forked version of this package. We would prefer to switch back to the original package, so we are hoping for a new release in the near future. It’s not urgent, but it would be greatly appreciated.

Thank you for your efforts!

@w666
Copy link
Collaborator

w666 commented May 1, 2024

@benasher44 I don't think I have permissions to enable issues tab. I will ask project owner if I remember about it.

@w666
Copy link
Collaborator

w666 commented May 1, 2024

@sandrozbinden-axa I will have a look on other changes that may be included into next release. Feel free to suggest pull-requests that maybe useful. I will try to release new version later this week or early next week, but depends on free time.

Thanks for pointing out on changes that are needed by community.

@w666 w666 merged commit c08ae8e into vpulim:master May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants