Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated axios and axios-ntlm to latest #1212

Merged
merged 7 commits into from Apr 5, 2024
Merged

Conversation

vision10
Copy link
Contributor

@vision10 vision10 commented Feb 10, 2023

latest version of axios-ntlm fixes node v18 digital envelope error
Error: error:0308010C:digital envelope routines::unsupported

updated axios to latest: 1.3.2
updated axios-ntlm to latest: 1.4.0 (uses axios 1.3.2)

also 2 tests where failing because of hardcoded response Content-Length

this request needs to be accepted to pass all tests: #1206

@h3llrais3r
Copy link

Would like to see this update as well!

@valdiss
Copy link

valdiss commented Mar 9, 2023

Same here, we're upgrading to node 18 and now need to --force to do any npm install...

@RezaRahmati
Copy link

Looking forward to get this changes

@T4kumi-js
Copy link

Looking forward to see this update too!

@jsdevel
Copy link
Collaborator

jsdevel commented Apr 14, 2023

@vision10 plz fix the build

@vision10
Copy link
Contributor Author

@jsdevel I have included changes from #1206
build should be ok

@lsaadeh
Copy link

lsaadeh commented Apr 21, 2023

@jsdevel are we happy to merge now?

@vision10
Copy link
Contributor Author

is there no one able to merge here?
axios is already at 1.4.0 since this pull request
some of the other pull requests can be closed or just need a bit of attention

@T4kumi-js
Copy link

idk, this seems like a sleeping law in congress

@colinramsay
Copy link

Sorry to be that guy, but could this get merged and released? It's blocking us at the moment.

@RezaRahmati
Copy link

RezaRahmati commented May 17, 2023

We might need to sign a petition for this PR to get merged 😆

@SaundersB
Copy link

Agreed it would be great to see this merged

@irothenbaum
Copy link

Bump. Is anyone still maintaining this repo?

@Parvenu
Copy link

Parvenu commented Jun 19, 2023

Bump, will this be merged someday ?

@guilhermeledes
Copy link

Bump. This is a critical update.

@codersbet
Copy link

Any update on this one @vpulim

@SaundersB
Copy link

FYI. In order to continue to use this package we all need to now use --force or --legacy-peer-deps until this is merged. Or we will need to find an alternative. Can we maybe delegate somebody to maintain this library since there are many of us who would contribute to resolve things like this?

@salarihamid
Copy link

+1

2 similar comments
@zindont
Copy link

zindont commented Jul 23, 2023

+1

@pedrokaroth
Copy link

+1

@DydjyZ
Copy link

DydjyZ commented Jul 26, 2023

sdfghujiopm

@kenzik
Copy link

kenzik commented Aug 8, 2023

What-the... Bump.

@random42
Copy link

random42 commented Aug 9, 2023

Hi, why is axios a peer dependency any way? I can't see the reason. If we could move it as a normal dependency we wouldn't be here waiting for using axios 1.0 and this library together.

@RJWerning
Copy link

RJWerning commented Aug 11, 2023

You can solve this issue without waiting for the PR to be merged, seems like this might be a dead project. In your package.json just add the following to overrides:

"dependencies": {
...
},
"overrides": {
"soap": {
"axios": "^1.0.0"
}
},
"devDependencies": {
...
},

@antirek
Copy link

antirek commented Aug 26, 2023

+1

@AdrianFahrbach
Copy link

Same here!
@vpulim Any chance to get this merged?

@nicolae536
Copy link

Any timeline for when this pr will be merged and released ? 🤔

@lukeTheWizard
Copy link

Merge please this is ruining the package

@vision10
Copy link
Contributor Author

We seriously need someone to accept these pull requests that are piling up, not just mine
@vpulim please give someone access to manage this repository if you are too busy

axios version has known vulnerabilities
https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459

@alfaproject
Copy link

@RJWerning can you confirm that the override works? I didn't want to risk it because it's a major version upgrade but now there's this new security vulnerability...

@codersbet
Copy link

If I fork this repo and start maintaining it will someone also help out?

I am planning on forking it to a new repo and start maintaining it. Who is in?

@derodero24
Copy link

@codersbet Although I may not be able to actively participate in the maintenance, I'm very supportive of the idea if you're willing to take the lead in managing it.

@RishikeshDarandale
Copy link
Contributor

@vpulim , Can you please merge this one?

@codersbet , @rmarfil3 created the fork, but not sure if he is publishing it to npm!

@vpulim vpulim merged commit 509b915 into vpulim:master Apr 5, 2024
1 check passed
@kevinccbsg
Copy link

Hi @vpulim thanks a lot for this package. When do you think it will be ready the new release?

@savez
Copy link

savez commented Apr 18, 2024

Warning.

axios 1.6.1 has an error.

With soap@1.0.1 I have an error in my unit test with this message: 'Cannot use import statement outside a module'.

I have reverted back to version 1.0.0 and have no errors.

@w666
Copy link
Collaborator

w666 commented Apr 18, 2024

Hi @savez, could you please add some details, like your environment and logs?
I've tested 1.0.1 release in my project and it worked just fine. We run it in node.js 20.

@w666
Copy link
Collaborator

w666 commented Apr 18, 2024

Hi @vpulim thanks a lot for this package. When do you think it will be ready the new release?

New version 1.0.1 has been released.

@savez
Copy link

savez commented Apr 18, 2024

Hi @savez, could you please add some details, like your environment and logs?
I've tested 1.0.1 release in my project and it worked just fine. We run it in node.js 20.

Yes,
I'm using node20.

But when I running jest it show an error.

@w666
Copy link
Collaborator

w666 commented Apr 18, 2024

If you can post your jest config and tsconfig that would help to identify the problem.
In my tests I just mock soap requests so don't really use it.
Unfortunately, I am very limited in time and can't setup test project to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet