Capsuleの当たり判定を修正 #2291 #2292
Merged
Capsuleの当たり判定を修正 #2291 #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
reviewed
May 30, 2024
| @@ -156,24 +156,31 @@ private static Quaternion Normalize(Quaternion q) | |||
| BlittableLogic logic, | |||
| ref Vector3 nextTail) | |||
| { | |||
| var P = (worldTail - worldPosition).normalized; | |||
| var direction = worldTail - worldPosition; | |||
| if (direction.sqrMagnitude == 0) | |||
There was a problem hiding this comment.
head と tail が同じ場所にある場合。単なる球として処理する
ousttrue
reviewed
May 30, 2024
| var Q = headTransform.position - worldPosition; | ||
| var dot = Vector3.Dot(P, Q); | ||
| if (dot <= 0) | ||
| { | ||
| // head側半球の球判定 | ||
| ResolveSphereCollision(joint, collider, worldPosition, headTransform, maxColliderScale, logic, ref nextTail); | ||
| return; |
ousttrue
reviewed
May 30, 2024
| { | ||
| // tail側半球の球判定 | ||
| ResolveSphereCollision(joint, collider, worldTail, headTransform, maxColliderScale, logic, ref nextTail); | ||
| return; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2291
について提案させていただきます。ご検討いただければと思います。