Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mjs cjs config file for jest #2346

Merged

Conversation

xiaoxiangmoe
Copy link
Contributor

@xiaoxiangmoe xiaoxiangmoe commented Jan 22, 2020

Fixes #IssueNumber

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

jestjs/jest#9291
jestjs/jest#9431


also:

jest.json, .jestrc(.*) seems useless, can we remove it? @Thiht @JimiC

It seems that these unofficial extensions are used by many repos.

Copy link
Member

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

@KingDarBoja KingDarBoja added this to the Next milestone Feb 13, 2020
@robertohuertasm robertohuertasm merged commit b03a61e into vscode-icons:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants