Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces incorrect link in CHANGELOG.md #2377

Merged
merged 1 commit into from Feb 17, 2020
Merged

Replaces incorrect link in CHANGELOG.md #2377

merged 1 commit into from Feb 17, 2020

Conversation

afflexux
Copy link
Contributor

@afflexux afflexux commented Feb 17, 2020

Fixes - No Issue Present

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Replaces link #2328 with #2298

@JimiC JimiC merged commit b864570 into vscode-icons:master Feb 17, 2020
Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Since it has already been merged, would you mind submitting another PR putting it in the correct order according to its new PR number? Many thanks!

@afflexux
Copy link
Contributor Author

Hi, no problem. Do you mean just submit again as is or do I have to add the PR number (#2377) somewhere?

Sorry, I'm quite new to PR's, kinda learning as I go along!

@robertohuertasm
Copy link
Member

No problem, you will acquire more experience by doing a new PR then 😉

If you look into the changelog you'll notice the entries are ordered by PR number. As you corrected the number from 2328 to 2298, now this PR should be the first one and not the second one.

So this new PR should move 2298 line before 2305:

Instead of this:

Feature: Support for Nuxt folder. (@KingDarBoja in #2298)
Enhancement: Enhance the existing Perl icon. (@KingDarBoja in #2305)

This:

Enhancement: Enhance the existing Perl icon. (@KingDarBoja in #2305)
Feature: Support for Nuxt folder. (@KingDarBoja in #2298)

Hope it's clearer now. Thanks for your help!

@afflexux
Copy link
Contributor Author

Aha!, I see what you mean.

Thank you for taking the time to explain and all the great work on this extension.

@robertohuertasm robertohuertasm added this to the Next milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants