Fix typescript-eslint plugin 2.22.0

[KingDarBoja]

Fixes #2396

Changes proposed:

• Add
• Delete
• Fix
• Prepare

[JimiC]

We do mass updates before release. Usually.

[robertohuertasm]

Why closing this? I don't see the problem.

[JimiC]

@robertohuertasm do u want to have to write entries in change log for every dependency update? Be my guest. From my pov it's better to do mass dependency updates.

[robertohuertasm]

Generally speaking, I agree. But for this one, which included manual @KingDarBoja changes I thought it would be ok. I don't mind writing one extra log entry if that means saving anyone from repeating again the same task.. 😊

[JimiC]

Even though it's best to keep dependencies updates tight. @KingDarBoja can include these changes on the mass update.

[JimiC]

Additional, I had a look at the release notes. The changes Manuel did to the rule are trivial as those are the default values.

https://github.com/typescript-eslint/typescript-eslint/blob/5a097d316fb084dc4b13e87d68fe9bf43d8a9548/packages/eslint-plugin/src/rules/type-annotation-spacing.ts#L60

[JimiC]

On the same note I plan on doing some cleanup on the rules. I already done so on my projects as a testing ground.

[robertohuertasm]

Fair enough! 👍🏻👌🏻

[KingDarBoja]

@JimiC Those changes seem to be the default values until you try to fix the spacing before the arrow (or after the colon?) and save the file (compositionRootService - line 24), the lint-stage hook will automatically remove the space and once again, trigger the ESLint warning.

Also, the overrides of variable seems to do the work, as the colon setting doesn't work as stated on the docs.

The issue lies on this line:

type Class = new (...args: any[]) => any;

Without the extra setting, it will be autoformatted like:

type Class = new (...args: any[])=> any;

[JimiC]

I'll have a look at it.

[robertohuertasm]

Shall we reopen this to not keep track of it?

[JimiC]

Give me some time pls.

[JimiC]

After testing it the rule has issues.

First of all the correct syntax when using options is:

"@typescript-eslint/type-annotation-spacing": [
      "error",
      {
        "overrides": {
          "arrow": {
            "before": true,
            "after": true
          }
        }
      }
    ],

but even using it, it produces the same error. My syggestion is to wait untill a fix is provided (I may get involved in this).

[JimiC]

The issue is caused by the rule not recognizing the new keyword.
type Class = new (...args: any[]) => any; fails but type Class = (...args: any[]) => any; passes but then the type annotation fails.

[JimiC]

Resolved: typescript-eslint/typescript-eslint#1664