Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): add icon for rnc files #3489

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

remcohaszing
Copy link
Contributor

RNC files are used for XML validation. There is an icon available on https://github.com/relaxng, but it’s very detailed and there’s no SVG version available. Instead the same icon is used as for XML, but with the same cyan color as is used in the original icon.

The rnc language ID is registered by
https://marketplace.visualstudio.com/items?itemName=redhat.vscode-xml

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

RNC files are used for XML validation. There is an icon available on
https://github.com/relaxng, but it’s very detailed and there’s no SVG
version available. Instead the same icon is used as for XML,
but with the same cyan color as is used in the original icon.

The `rnc` language ID is registered by
https://marketplace.visualstudio.com/items?itemName=redhat.vscode-xml
Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for your contribution ❤️

@robertohuertasm robertohuertasm added this to the Next milestone Jun 1, 2024
@robertohuertasm robertohuertasm merged commit 7d34ee8 into vscode-icons:master Jun 1, 2024
16 checks passed
@remcohaszing remcohaszing deleted the rnc branch June 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants