Test fixes. #1242
Merged
Test fixes. #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsinnit
force-pushed
the
redo/timswork
branch
13 times, most recently
from
2811ad6
to
06d9903
Compare
Tatsinnit
changed the title
Tatsinnit
force-pushed
the
redo/timswork
branch
4 times, most recently
from
67a78e8
to
aa4ec4a
Compare
peterbom
approved these changes
Jan 15, 2024
Tatsinnit
force-pushed
the
redo/timswork
branch
from
aa4ec4a
to
2496370
Compare
Signed-off-by: Tatsinnit <Tatsinnit@users.noreply.github.com>
Tatsinnit
force-pushed
the
redo/timswork
branch
from
2496370
to
c83adf1
Compare
Signed-off-by: Tatsinnit <Tatsinnit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test redo for the Tim's work. Along with a key test failure which is happening due to the deprecation ofvscode-testvscode-testis deprecated. https://www.npmjs.com/package/vscode-testThis PR also take care of #1232 which had some signo-off issue.Hence an fyi to @timheuer and thank you so much to #1232 - a gentle ping as fyi and your contribution ischerry-pickedhence it will be maintained against this repo. ❤️☕️🙏It takes care of this sign-off over-write which makes the last release as part of the other PR.Thank you again and gentle - ❤️🙏 cc: @squillace , @gambtho and @peterbom for eye balling, there is whole lot of dependency update needed which I will align next.
Alsso just for context building: webpack/webpack#14532
I will fix the issue for the PR #1232 separately.