-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Test Suite #166
base: master
Are you sure you want to change the base?
Fix: Test Suite #166
Conversation
Typescript should've been failing since vscode-restructuredtext@74cb99b because of this? Have the errors been suppressed somehow?
Again, not sure how this has been fine since vscode-restructuredtext@74cb99b#diff-2c164b81e38e45e3b6750f8376fa37f5R23
This will also create a notice if the logger class is ever updated
test-resources\sphinx> sphinx-build . _build\html test-resources\sphinx> cp _build\html\index.html ..
@lextm I'm wondering if there's a reason why there's no comment on this PR. Maintaining tests seems like a most commendable effort of cleanup and maintenance that should be especially welcome in open source projects. |
@oharboe the horrible part of running an open source project is to avoid taking everything. Note that the original preview code was take directly from VSCode Markdown extension, so that I can maintain that piece of code without much effort. The changed lines in this pull request (and its siblings) are not self explained and sometimes unnecessary. So if I am going to accept it, I need enough time (at least months) to really understand what it does. Time is luxury for such side projects. |
@lextm Time is a luxury indeed. The best one can do is to hope for more maintainers to present themselves(which requires time and grooming) and to try to give som quick guidance so the contributor can carry more of the load, like make the code more self explanatory so maintainability of master is not compromised. I appreciate that the stability and maitainability of master is paramount and that you can only take delivery when PRs are truly ready and there is no followup tasks for the community. |
Took a glance at the changes I made in this PR and I'm not sure what you want elaborated on. The implementation is still less than ideal ( I'm happy to finish this up whenever - LMK what needs changing as and when. |
There were a few issues causing the test suite to fail. This PR cleans them up so that work can be done on new features
RSTPreviewConfiguration.lineBreaks
:unknown
toboolean
CodeLineElement.element
:HTMLElement
toElement
test/extension.test.ts
{ [P in keyof Logger]: Logger[P] } as Logger
, enforcing the methods implementationconf.py
referenced the non-existent_static
folder, so that was removedsphinx
updates have caused the output of the build to change, so that was updatedsphinx
itself to check the content of the webview againstcompile
function could be run beforepython.setup
, leaving it without an interpreter to use.setup
, this meant it was impossible for thecompile
function to succeed. This was also a problem in use, causing a race condition between the language features and a preview being opened, so I changed it in the implementation