Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint problems + Fix tests #14

Merged
merged 4 commits into from May 13, 2020
Merged

Fix lint problems + Fix tests #14

merged 4 commits into from May 13, 2020

Conversation

Klynger
Copy link
Contributor

@Klynger Klynger commented May 11, 2020

What does this PR do? *

Add lint configuration + Fix lint problems + Fix tests + Update dependencies

How to test it? *

https://checkbox--unileverb2b.myvtex.com/#
image
Click in Registrar
It should run

The tests are not working yet, so I need some help guys

@Klynger Klynger self-assigned this May 11, 2020
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented May 11, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented May 11, 2020

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

CHANGELOG.md Outdated Show resolved Hide resolved
@kaisermann
Copy link
Contributor

Waiting for the next release of @typescript-eslint/eslint-plugin via typescript-eslint/typescript-eslint#2009

@Klynger Klynger marked this pull request as ready for review May 12, 2020 13:22
@Klynger Klynger requested a review from a team as a code owner May 12, 2020 13:22
react/components/Checkbox.tsx Outdated Show resolved Hide resolved
react/components/Checkbox.tsx Outdated Show resolved Hide resolved
@Klynger Klynger merged commit 688f596 into master May 13, 2020
@Klynger Klynger deleted the patch/update-lint branch May 13, 2020 19:26
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented May 13, 2020

Your PR has been merged! App is being published. 🚀
Version 0.3.4 → 0.3.5

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-form@0.3.5

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants