Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: husky pre-commit script + Lint-stage #1669

Merged
merged 1 commit into from Mar 15, 2023
Merged

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Mar 15, 2023

What's the purpose of this pull request?

Fix husky + lint-staged that runs pre-commit lints for core packages.

Before After
Screenshot 2023-03-15 at 16 57 30 Screenshot 2023-03-15 at 16 57 37

You should also see this scripts running pre commits:
Screenshot 2023-03-15 at 17 05 06

How to test it?

  • run yarn command.
  • you should see the pre commit lint tasks after a commit as well 😉

references

typicode/husky#851

@eduardoformiga eduardoformiga requested a review from a team as a code owner March 15, 2023 20:06
@eduardoformiga eduardoformiga requested review from danzanzini and emersonlaurentino and removed request for a team March 15, 2023 20:06
@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
faststore-site ✅ Ready (Inspect) Visit Preview Mar 15, 2023 at 8:07PM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ba41a5:

Sandbox Source
Store UI Typescript Configuration

@eduardoformiga eduardoformiga merged commit 5a3f3c8 into main Mar 15, 2023
5 checks passed
@eduardoformiga eduardoformiga deleted the fix/husky-lint-staged branch March 15, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants