Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): suppress unnecessary peerDeps warning #974

Conversation

ikatyang
Copy link
Contributor

  • peerDependenciesMeta is supported in npm, pnpm, yarn, and yarn 2
  • pug is not a necessary peer dependency, it should not need to be installed if lang="pug" is not used

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #974 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #974   +/-   ##
=======================================
  Coverage   63.97%   63.97%           
=======================================
  Files         175      175           
  Lines        4786     4786           
  Branches     1413     1413           
=======================================
  Hits         3062     3062           
  Misses       1652     1652           
  Partials       72       72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f871810...43cc772. Read the comment docs.

@elevatebart
Copy link
Member

Oh thank you @ikatyang!
Great PR! simple review, and I did not know about this peerDependenciesMeta.

You made my day

@elevatebart elevatebart merged commit 0b29587 into vue-styleguidist:dev Sep 16, 2020
@ikatyang ikatyang deleted the chore/deps/suppress-unnecessary-peerdeps-warnings branch September 16, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants