Enhanced dynamic directory #82
Conversation
| @@ -7,7 +7,7 @@ module.exports = { | |||
| index: path.resolve(__dirname, '../dist/index.html'), | |||
| assetsRoot: path.resolve(__dirname, '../dist'), | |||
| assetsSubDirectory: 'static', | |||
| assetsPublicPath: '/', | |||
| assetsPublicPath: './', | |||
There was a problem hiding this comment.
This change allows the production app running in any localhost/{PATH}, instead of localhost/ only
|
In general, changes to the build that are not specific to the PWA template should be made against the canonical config, which in this case is https://github.com/vuejs-templates/webpack/blob/develop/template/config/index.js#L58. Once that's reviewed and merged, we can make the equivalent change to the config used by the PWA template. This ensures that there's a degree of consistency between the two templates. |
| @@ -7,7 +7,7 @@ | |||
| <title>{{ name }}</title> | |||
| <link rel="icon" type="image/png" sizes="32x32" href="<%= htmlWebpackPlugin.files.publicPath %>static/img/icons/favicon-32x32.png"> | |||
| <link rel="icon" type="image/png" sizes="16x16" href="<%= htmlWebpackPlugin.files.publicPath %>static/img/icons/favicon-16x16.png"> | |||
| <!--[if IE]><link rel="shortcut icon" href="/static/img/icons/favicon.ico"><![endif]--> | |||
| <!--[if IE]><link rel="shortcut icon" href="<%= htmlWebpackPlugin.files.publicPath %>static/img/icons/favicon.ico"><![endif]--> | |||
There was a problem hiding this comment.
This seems like a reasonable change to make independent from https://github.com/vuejs-templates/pwa/pull/82/files#r142584472. If you wanted to modify the PR to just include this change, and leave out the other change for now, that would be mergeable.
No description provided.