docs: Documentation only changes #1433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Missing docs for sending custom or bearer headers.
Sindhani
changed the title
nickmessing
reviewed
Mar 26, 2024
Comment on lines
+442
to
+443
| // createUploadLink can be used as well | ||
| // jaydenseric/apollo-upload-client library for uploading files using apollo |
There was a problem hiding this comment.
I don't think file upload should be mentioned at all in vue-apollo docs, it's unrelated
nickmessing
reviewed
Mar 26, 2024
Comment on lines
+445
to
+458
| let link = createHttpLink({uri: url}) | ||
| link = setContext(async (_, {headers}) => { | ||
|
|
||
| // getToken() your defined function for getting the token | ||
| const Authorization = getToken() | ||
|
|
||
| const authorizationHeader = Authorization ? {Authorization} : {} | ||
| return { | ||
| headers: { | ||
| ...headers, | ||
| ...authorizationHeader, | ||
| }, | ||
| } | ||
| }).concat(link) |
There was a problem hiding this comment.
This is doing a few things in not-the-most-readable way.
What about having a separate const httpLink = ... and const authorzationHeaderLink = ... and then const link = authorzationHeaderLink.concat(httpLink)?
Authorization should probably not be uppercased, it's just a string.
And the code style in the docs has spaces inside curly braces.
nickmessing
reviewed
Mar 26, 2024
Comment on lines
+460
to
+463
| function getToken() { | ||
| const token = JSON.parse(localStorage.getItem('apollo-token')); | ||
| return `Bearer ${token}` || null; | ||
| } |
There was a problem hiding this comment.
This should probably be not included, getting the token shouldn't be part of the example IMO, wdyt @Akryum?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: Documentation only changes