Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change teardown to use onScopeDispose #1545

Merged
merged 2 commits into from
Mar 29, 2024
Merged

fix: change teardown to use onScopeDispose #1545

merged 2 commits into from
Mar 29, 2024

Conversation

nickmessing
Copy link
Member

This fixes #1538

⚠️ This is technically a breaking change because now the teardown happens onUnmounted instead of onBeforeUnmount, however I find it very unlikely to affect any real usecase

CC @Akryum

@Akryum Akryum merged commit 6fa46ab into vuejs:v4 Mar 29, 2024
9 checks passed
@nickmessing nickmessing deleted the nick/fix-apollo-in-pinia branch March 29, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Akryum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onBeforeUnmount hook in useQuery is undesirable when used in pinia store
2 participants
@nickmessing @Akryum