add jsx sync modifier #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egoist
reviewed
Jan 23, 2018
| @@ -34,7 +34,8 @@ | |||
| "babel-plugin-jsx-event-modifiers": "^2.0.2", | |||
| "babel-plugin-jsx-v-model": "^2.0.1", | |||
| "babel-plugin-syntax-jsx": "^6.18.0", | |||
| "babel-plugin-transform-vue-jsx": "^3.5.0" | |||
| "babel-plugin-transform-vue-jsx": "^3.5.0", | |||
| "babel-plugin-vue-jsx-sync": "^0.0.4" | |||
There was a problem hiding this comment.
seems it's still too young and lacks of tests?
There was a problem hiding this comment.
@egoist yeah, it's young 😂 . I use it in my own project, and it works currently. I can add some unit tests, if you think it is necessary.
There was a problem hiding this comment.
We should give it some time to mature first 😄
There was a problem hiding this comment.
@egoist OK, Tnx for your time.
There was a problem hiding this comment.
@egoist, maybe we can add sync to event-modifiers, what do you think?
There was a problem hiding this comment.
@njleonzhang, if you could make a PR to event-modifiers, I'd be very grateful
There was a problem hiding this comment.
@nickmessing, OK, I will try to make one after spring festival
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.