refactor: obj[key] have already triggered the getter (#914)

Co-authored-by: wavesheep <yanghaibo@youzan.com>
vuejs · Mar 29, 2022 · 000ffe4 · 000ffe4
1 parent b3296db
commit 000ffe4
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/reactivity/reactive.ts b/src/reactivity/reactive.ts
@@ -208,14 +208,13 @@ export function shallowReactive(obj: any) {
 
     proxy(observed, key, {
       get: function getterHandler() {
-        const value = getter ? getter.call(obj) : val
         ob.dep?.depend()
-        return value
+        return val
       },
       set: function setterHandler(newVal: any) {
         if (getter && !setter) return
-        const value = getter ? getter.call(obj) : val
-        if (!isForceTrigger() && value === newVal) return
+
+        if (!isForceTrigger() && val === newVal) return
         if (setter) {
           setter.call(obj, newVal)
         } else {