fix(runtime-core): custom-element: ensure event names are hyphenated

vuejs · Feb 8, 2022 · 3d55f46 · 3d55f46
1 parent 60cf175
commit 3d55f46
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/packages/runtime-dom/__tests__/customElement.spec.ts b/packages/runtime-dom/__tests__/customElement.spec.ts
@@ -218,7 +218,10 @@ describe('defineCustomElement', () => {
         emit('created')
         return () =>
           h('div', {
-            onClick: () => emit('my-click', 1)
+            onClick: () => {
+              emit('my-click', 1)
+              emit('myClick', 1) // validate hypenization
+            }
           })
       }
     })
@@ -238,10 +241,13 @@ describe('defineCustomElement', () => {
       const spy = jest.fn()
       e.addEventListener('my-click', spy)
       e.shadowRoot!.childNodes[0].dispatchEvent(new CustomEvent('click'))
-      expect(spy).toHaveBeenCalled()
+      expect(spy).toHaveBeenCalledTimes(2)
       expect(spy.mock.calls[0][0]).toMatchObject({
         detail: [1]
       })
+      expect(spy.mock.calls[1][0]).toMatchObject({
+        detail: [1]
+      })
     })
   })
 

diff --git a/packages/runtime-dom/src/apiCustomElement.ts b/packages/runtime-dom/src/apiCustomElement.ts
@@ -340,7 +340,7 @@ export class VueElement extends BaseClass {
         // intercept emit
         instance.emit = (event: string, ...args: any[]) => {
           this.dispatchEvent(
-            new CustomEvent(event, {
+            new CustomEvent(hyphenate(event), {
               detail: args
             })
           )