chore: remove duplicated test + add missing prop decl

vuejs · May 28, 2022 · 439377b · 439377b
1 parent 3cfe5f9
commit 439377b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 33 deletions.
diff --git a/packages/runtime-core/__tests__/apiLifecycle.spec.ts b/packages/runtime-core/__tests__/apiLifecycle.spec.ts
@@ -231,6 +231,7 @@ describe('api: lifecycle hooks', () => {
     }
 
     const Mid = {
+      props: ['count'],
       setup(props: any) {
         onBeforeMount(() => calls.push('mid onBeforeMount'))
         onMounted(() => calls.push('mid onMounted'))
@@ -243,6 +244,7 @@ describe('api: lifecycle hooks', () => {
     }
 
     const Child = {
+      props: ['count'],
       setup(props: any) {
         onBeforeMount(() => calls.push('child onBeforeMount'))
         onMounted(() => calls.push('child onMounted'))

diff --git a/packages/runtime-core/__tests__/apiSetupContext.spec.ts b/packages/runtime-core/__tests__/apiSetupContext.spec.ts
@@ -75,39 +75,6 @@ describe('api: setup context', () => {
     expect(dummy).toBe(1)
   })
 
-  it('setup props should resolve the correct types from props object', async () => {
-    const count = ref(0)
-    let dummy
-
-    const Parent = {
-      render: () => h(Child, { count: count.value })
-    }
-
-    const Child = defineComponent({
-      props: {
-        count: Number
-      },
-
-      setup(props) {
-        watchEffect(() => {
-          dummy = props.count
-        })
-        return () => h('div', props.count)
-      }
-    })
-
-    const root = nodeOps.createElement('div')
-    render(h(Parent), root)
-    expect(serializeInner(root)).toMatch(`<div>0</div>`)
-    expect(dummy).toBe(0)
-
-    // props should be reactive
-    count.value++
-    await nextTick()
-    expect(serializeInner(root)).toMatch(`<div>1</div>`)
-    expect(dummy).toBe(1)
-  })
-
   it('context.attrs', async () => {
     const toggle = ref(true)