Skip to content

Commit

Permalink
ci: disable format-check on ci
Browse files Browse the repository at this point in the history 
this causes too many unintended fails on PR merges
the task should just be manually run periodically
  • Loading branch information
@yyx990803
yyx990803 committed Nov 8, 2022
1 parent 9906e3a commit b3916db
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Expand Up @@ -68,8 +68,8 @@ jobs:
- name: Run eslint
run: pnpm run lint

- name: Run prettier
run: pnpm run format-check
# - name: Run prettier
# run: pnpm run format-check

- name: Run type declaration tests
run: pnpm run test-dts
Expand Down

1 comment on commit b3916db

@sxzz
Copy link
Member

@sxzz sxzz commented on b3916db Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't check it, I have to quite often remind many authors to format the files during the review.
Also, I think manually running periodically may produce extra formatting noise.

WDYT?

Please sign in to comment.