refactor: tweaks

vuejs · May 19, 2023 · b84e544 · b84e544
1 parent 1c049d9
commit b84e544
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/runtime-core/src/component.ts b/packages/runtime-core/src/component.ts
@@ -905,8 +905,8 @@ export function finishComponentSetup(
     pauseTracking()
     try {
       applyOptions(instance)
-      resetTracking()
     } finally {
+      resetTracking()
       unsetCurrentInstance()
     }
   }

diff --git a/packages/server-renderer/__tests__/render.spec.ts b/packages/server-renderer/__tests__/render.spec.ts
@@ -817,21 +817,24 @@ function testRender(type: string, render: typeof renderToString) {
       const prev = getCurrentInstance()
 
       expect(prev).toBe(null)
+
+      const Child = {
+        created() {
+          throw new Error()
+        }
+      }
       try {
         await render(
           createApp({
             errorCaptured() {
               throw new Error()
             },
-            template: `<div>hello</div>`,
-            created() {
-              throw new Error()
-            }
+            render: () => h(Child)
           })
         )
       } catch {}
       expect(
-        'Unhandled error during execution of created hook'
+        'Unhandled error during execution of errorCaptured hook'
       ).toHaveBeenWarned()
       expect(getCurrentInstance()).toBe(null)
     })