Skip to content

Commit

Permalink
fix(compiler-sfc): fix props codegen w/ leading import
Browse files Browse the repository at this point in the history
fix #4764
  • Loading branch information
yyx990803 committed Oct 8, 2021
1 parent 9e3d773 commit d4c04e9
Show file tree
Hide file tree
Showing 4 changed files with 51 additions and 14 deletions.
Expand Up @@ -58,7 +58,7 @@ exports[`SFC compile <script setup> <script> and <script setup> co-usage spaces
"import { x } from './x'
export const n = 1
const __default__ = {
const __default__ = {
some:'option'
}
Expand All @@ -79,7 +79,7 @@ exports[`SFC compile <script setup> <script> and <script setup> co-usage spaces
"import { x } from './x'
export const n = 1
const __default__ = {
const __default__ = {
some:'option'
}
Expand Down Expand Up @@ -392,6 +392,7 @@ export default {
expose()
const props = __props
return { props, propsModel }
Expand All @@ -400,6 +401,23 @@ return { props, propsModel }
}"
`;
exports[`SFC compile <script setup> defineProps w/ leading code 1`] = `
"import { x } from './x'
export default {
props: {},
setup(__props, { expose }) {
expose()
const props = __props
return { props, x }
}
}"
`;
exports[`SFC compile <script setup> defineProps() 1`] = `
"export default {
props: {
Expand All @@ -410,6 +428,7 @@ exports[`SFC compile <script setup> defineProps() 1`] = `
const props = __props
const bar = 1
return { props, bar }
Expand All @@ -426,6 +445,7 @@ exports[`SFC compile <script setup> defineProps/defineEmits in multi-variable de
expose()
const props = __props
return { props, emit }
Expand All @@ -442,6 +462,7 @@ exports[`SFC compile <script setup> defineProps/defineEmits in multi-variable de
expose()
const props = __props
const a = 1;
return { props, a, emit }
Expand Down Expand Up @@ -814,7 +835,7 @@ return (_ctx, _cache) => {
}),
_createElementVNode(\\"div\\", {
onClick: _cache[5] || (_cache[5] = () => {
let a = '' + _unref(lett)
let a = '' + _unref(lett)
_isRef(v) ? v.value = a : v = a
})
}),
Expand All @@ -828,7 +849,7 @@ return (_ctx, _cache) => {
let z2 = z
})
let lz = _ctx.z
})
})
_isRef(v) ? v.value = _ctx.a : v = _ctx.a
})
})
Expand Down Expand Up @@ -1286,6 +1307,7 @@ const props = __props
return { props, emit }
}
Expand Down Expand Up @@ -1360,6 +1382,7 @@ const props = __props as {
bar?: number
baz: boolean
}
return { props, defaults }
Expand All @@ -1382,6 +1405,7 @@ export default /*#__PURE__*/_defineComponent({
expose()
const props = __props as { foo: string, bar?: number, baz: boolean, qux(): number }
return { props }
Expand Down
Expand Up @@ -119,6 +119,7 @@ export default {
setup(__props) {
const rest = _createPropsRestProxy(__props, [\\"foo\\",\\"bar\\"])
return () => {}
Expand Down
22 changes: 17 additions & 5 deletions packages/compiler-sfc/__tests__/compileScript.spec.ts
Expand Up @@ -96,6 +96,18 @@ const bar = 1
props: propsModel,`)
})

// #4764
test('defineProps w/ leading code', () => {
const { content } = compile(`
<script setup>import { x } from './x'
const props = defineProps({})
</script>
`)
// props declaration should be inside setup, not moved along with the import
expect(content).not.toMatch(`const props = __props\nimport`)
assertCode(content)
})

test('defineEmits()', () => {
const { content, bindings } = compile(`
<script setup>
Expand Down Expand Up @@ -164,8 +176,8 @@ defineExpose({ foo: 123 })
const { content } = compile(`
<script>
export const n = 1
export default
{
export default
{
some:'option'
}
</script>
Expand All @@ -181,7 +193,7 @@ defineExpose({ foo: 123 })
const { content } = compile(`
<script>
export const n = 1
export default{
export default{
some:'option'
}
</script>
Expand Down Expand Up @@ -549,7 +561,7 @@ defineExpose({ foo: 123 })
<div @click="v += 1"/>
<div @click="v -= 1"/>
<div @click="() => {
let a = '' + lett
let a = '' + lett
v = a
}"/>
<div @click="() => {
Expand All @@ -561,7 +573,7 @@ defineExpose({ foo: 123 })
let z2 = z
})
let lz = z
})
})
v = a
}"/>
</template>
Expand Down
10 changes: 5 additions & 5 deletions packages/compiler-sfc/src/compileScript.ts
Expand Up @@ -1205,25 +1205,25 @@ export function compileScript(
// we use a default __props so that template expressions referencing props
// can use it directly
if (propsIdentifier) {
s.prependRight(
s.prependLeft(
startOffset,
`\nconst ${propsIdentifier} = __props${
propsTypeDecl ? ` as ${genSetupPropsType(propsTypeDecl)}` : ``
}`
}\n`
)
}
if (propsDestructureRestId) {
s.prependRight(
s.prependLeft(
startOffset,
`\nconst ${propsDestructureRestId} = ${helper(
`createPropsRestProxy`
)}(__props, ${JSON.stringify(Object.keys(propsDestructuredBindings))})`
)}(__props, ${JSON.stringify(Object.keys(propsDestructuredBindings))})\n`
)
}
// inject temp variables for async context preservation
if (hasAwait) {
const any = isTS ? `: any` : ``
s.prependRight(startOffset, `\nlet __temp${any}, __restore${any}\n`)
s.prependLeft(startOffset, `\nlet __temp${any}, __restore${any}\n`)
}

const destructureElements =
Expand Down

0 comments on commit d4c04e9

Please sign in to comment.