Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suspensible option throws error when child of suspense is not async in SSR #8265

Closed
baiwusanyu-c opened this issue May 10, 2023 · 0 comments · Fixed by #8259
Closed

suspensible option throws error when child of suspense is not async in SSR #8265

baiwusanyu-c opened this issue May 10, 2023 · 0 comments · Fixed by #8259

Comments

@baiwusanyu-c
Copy link
Member

baiwusanyu-c commented May 10, 2023

Vue version

v3.3.0-beta5

Link to minimal reproduction

https://play.vuejs.org/#eNptUMtqwzAQ/JXBF9lgqlx6KU4g9AcK6bEX19lggS0JSXYoxv/elWT3RS+SdmY0O7tLcbb2YZ6oeCoa3zllAzyFyZ7eNKBGa1zAgivdlKaz/9Dds2FQkw41eqy4OTNCsIGIHzqjfcCFZThiiQiyXVntJeAYcBoMHU/oS3FVs6gheoXQkyNRZeEar3Rk19Sdbf/LUraJzJZbo/beqgBNd7xwRuWpdOTNMFPUcKhXNZKZwo7WeDwcqq33FjEOklIw3Mi8Hl4MF4FGO7SB0pqay+QtaZ8rrnmi7fmDhM8P9T7swszH5PJbL/+6yd3uF9XIrwzF+gnIkZOe

Steps to reproduce

<script setup>
  import { defineAsyncComponent, h } from 'vue'
  const Sync = {
    setup() {
      return () => h('div', 'hi there')
    }
  }
  const Async = defineAsyncComponent(async () => {
    await new Promise(resolve => setTimeout(resolve, 500))
    return Sync
  })
</script>

<template>
  <Suspense>
    <div>
      <Suspense suspensible>
        <Sync />
      </Suspense>
    </div>
  </Suspense>
</template>

Load page with a synchronous component under and Switch to SSR mode,the following error will be displayed:

suspense.resolve() is called without a pending branch.

What is expected?

I expect that should work with both async + sync components.

What is actually happening?

error will be displayed:

suspense.resolve() is called without a pending branch.

System Info

No response

Any additional comments?

The problem is the same as the #8206 , except in e147512 we forgot to handle hydration

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant