Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suspense): fix nested suspensible suspense with no asyn deps in ssr #8259

Merged
merged 1 commit into from
May 11, 2023

Conversation

baiwusanyu-c
Copy link
Member

@baiwusanyu-c baiwusanyu-c commented May 9, 2023

close: #8265
relate:
e147512
#8242
#8206

@baiwusanyu-c
Copy link
Member Author

Do you think a new unit test needs to be added?
@yyx990803

@edison1105
Copy link
Member

@baiwusanyu-c

relate:
62e71b5

should be e147512

@baiwusanyu-c
Copy link
Member Author

@baiwusanyu-c

relate:
62e71b5

should be e147512

ok~

@baiwusanyu-c baiwusanyu-c changed the title fix(runtime-core): Suspense can correctly call the resolved of parent suspense when there is no async deps fix(suspense): fix nested suspensible suspense with no asyn deps in ssr May 10, 2023
@yyx990803 yyx990803 merged commit 34671b3 into vuejs:main May 11, 2023
11 checks passed
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/suspenseSyncSSR branch May 11, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suspensible option throws error when child of suspense is not async in SSR
4 participants