fix(runtime-core): expose type using generics #10486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelDeMartin
changed the title
NoelDeMartin
force-pushed
the
expose-generics
branch
from
46731ea
to
5e2ab96
Compare
Size ReportBundles
Usages
|
Makes it consistent with the definition of defineExpose
NoelDeMartin
force-pushed
the
expose-generics
branch
from
f349131
to
fa52619
Compare
|
Does this replace #8507? |
|
Lol, it seems like I forgot that I had already opened this PR 😅. Thanks for the heads-up @skirtles-code, I'm closing this as a duplicate then. I'm pinging one of the maintainers @sodatea to take a look, it seems like a fairly safe fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it consistent with the definition of defineExpose. Without this change, using the generic parameter on
defineExposethrows a compilation error.