Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-element): reflect prop default value #10537

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #9006

Copy link

github-actions bot commented Mar 17, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.8 kB (+70 B) 34.5 kB (+29 B) 31.1 kB (+30 B)
vue.global.prod.js 148 kB (+70 B) 53.8 kB (+33 B) 48.1 kB (+35 B)

Usages

Name Size Gzip Brotli
createApp 50.8 kB (+25 B) 19.9 kB (+15 B) 18.1 kB (+14 B)
createSSRApp 54.2 kB (+25 B) 21.2 kB (+15 B) 19.3 kB (+14 B)
defineCustomElement 53.2 kB (+70 B) 20.6 kB (+26 B) 18.8 kB (+51 B)
overall 64.6 kB (+25 B) 24.9 kB (+16 B) 22.6 kB (+25 B)

@mgibas
Copy link

mgibas commented Mar 19, 2024

I’m pretty sure if you’ll set an attribute (setProp-> reflect attr) inside of the constructor, real browser will throw an exception :(

@edison1105 edison1105 marked this pull request as draft March 19, 2024 03:53
@edison1105 edison1105 marked this pull request as ready for review March 19, 2024 09:45
@edison1105 edison1105 changed the title fix(custom-element): handle props default value on initial render fix(custom-element): reflect prop default value Apr 21, 2024
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Apr 21, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt failure success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure failure
vueuse success success
vue-simple-compiler success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default prop value is not reflected in custom element property
5 participants