New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(event): addEventListener set passive option to false by default #10751
Conversation
Size ReportBundles
Usages
|
What you want is |
No, the |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not sure if I understand your problem, in what browsers are these warnings shown? I can't reproduce them. |
From my understanding:
So the point of this PR is just to suppress the warning but the code is still doing what it warns you against. If that's the case, I don't think this PR makes sense. Vue should not default to hiding meaningful warnings. |
When I bind the
wheel
event to the input, and then calle.preventDefault()
to prevent the default event under certain circumstances, a warning message will appear on the console.example