fix(shared): ensure invokeArrayFns handles undefined arguments #10869
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
|
Is it possible to include test cases for this fix? |
jh-leong
force-pushed
the
fix/invokeArrayFns
branch
from
5cd0973
to
92d4caf
Compare
Yes, I have updated the tests to cover this fix. Thank you for your suggestion! |
sodatea
approved these changes
May 15, 2024
sodatea
reviewed
May 15, 2024
jh-leong
force-pushed
the
fix/invokeArrayFns
branch
from
92d4caf
to
3a5dd5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #10863.
Ensures
invokeArrayFnsin shared/src/general.ts handles undefined arguments properly.