types(runtime-core): fix types of createElementBlock and createBlock #4411
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HcySunYang
reviewed
Aug 22, 2021
| type: string, | ||
| props?: Record<string, any> | null, | ||
| children?: any, | ||
| type: VNodeTypes | ClassComponent | typeof NULL_DYNAMIC_COMPONENT, |
There was a problem hiding this comment.
Strictly speaking, the type cannot be a component type.
There was a problem hiding this comment.
Why is that and why isn't that reflected in createBaseVNode?
There was a problem hiding this comment.
createElementBlock will only be generated in callsites where the argument is either a plain element or a fragment. This is defined by how it is generated by the compiler.
|
These functions are only used in compiler-generated code so their type checking should be lax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4391
supersedes: #4406
This aligns the arguments of
createElementBlockandcreateBlockcloser to the ones of the underlyingcreateBaseVNodeandcreateVNode.packages/runtime-core/src/helpers/renderSlot.ts had to be changed since the type of
props.keyhad to bestring | number | symbol | undefinedinstead ofunknown.I already tested it with my fail case (#4391) and it fixes the issue.