New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): destructure StringLiteral key not register bindings (fix #4540) #4541

Closed

JuniorTour wants to merge 1 commit into vuejs:master from JuniorTour:patch-1

JuniorTour commented Sep 9, 2021 •

edited

	Before Fix #4540	After Fix #4540
Screenshot


          fix(compiler-sfc): destructure StringLiteral key not register bindings (

c1911ae

fix vuejs#4540)

Member

yyx990803 commented Sep 9, 2021

Thanks for the PR, but in fact with a dynamic key the key node can be any expression type. See more complete fix in a6e5f82

yyx990803 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment