fix(compiler-sfc): #4581 getImportsExpressionExp with hash #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subsequent calls with an url already in the import cache and with a hash returns the correct expression including each time the hash if one.
|
Thanks for the PR - I think a better fix would be reusing the hoisted fragment URLs when possible. See 06c5bf5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4581
Subsequent calls with an url already in the import cache
and with a hash returns the correct expression including each time the
hash if one.
NOTE: this relies on the fact that
exp.contentis assigned the variablename, since it's the only way to get it back from the cache, and that feels "hacky". A better solution may be possible