Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the latest vue3 version cause ssr failed, devtools judge in server side is not exact #4890

Merged
merged 2 commits into from Nov 15, 2021
Merged

fix: the latest vue3 version cause ssr failed, devtools judge in server side is not exact #4890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6a5e63
fix: devtools judge in server side
zhangyuang Nov 3, 2021
e9e27e9
Update devtools.ts
yyx990803 Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/runtime-core/src/devtools.ts
View file
Open in desktop
Expand Up @@ -55,7 +55,10 @@ export function setDevtoolsHook(hook: DevtoolsHook, target: any) {
// (#4815)
// eslint-disable-next-line no-restricted-globals
typeof window !== 'undefined' &&
!navigator.userAgent.includes('jsdom')
// some envs mock window but not fully
window.HTMLElement &&
// also exclude jsdom
!window.navigator?.userAgent?.includes('jsdom')
) {
const replay = (target.__VUE_DEVTOOLS_HOOK_REPLAY__ =
target.__VUE_DEVTOOLS_HOOK_REPLAY__ || [])
Expand Down