fix(runtime-core): ensure that binding.instance in custom directive hooks has access to exposed properties on closed instances (fix: #5018) #5021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For closed instances (those crreated with
<script setup>or a normal setup function in whichexpose()has been called), we currently expose a different proxy for i.e. refs.This proxy provides access to the public instance methods provided by Vue and the explicitly exposed custom properties.
This PR not also exposes this same proxy to custom directives in
binding-instanceso that custom directives can access exposed properties correctly.fix: #5018