Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): handle v-memo in template v-for #5291

Merged
merged 2 commits into from Jan 21, 2022
Merged

fix(compiler-core): handle v-memo in template v-for #5291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ee27ac
fix(compiler-core): handle v-memo in template v-for
edison1105 Jan 19, 2022
06aba4a
Update vFor.ts
yyx990803 Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compiler-core/__tests__/transforms/__snapshots__/vMemo.spec.ts.snap
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ exports[`compiler: v-memo transform on template v-for 1`] = `
export function render(_ctx, _cache) {
return (_openBlock(), _createElementBlock(\\"div\\", null, [
(_openBlock(true), _createElementBlock(_Fragment, null, _renderList(_ctx.list, ({ x, y }, __, ___, _cached) => {
const _memo = ([x, y === z])
const _memo = ([x, y === _ctx.z])
if (_cached && _cached.key === x && _isMemoSame(_cached, _memo)) return _cached
const _item = (_openBlock(), _createElementBlock(\\"span\\", { key: x }, \\"foobar\\"))
_item.memo = _memo
Expand Down
8 changes: 8 additions & 0 deletions packages/compiler-core/src/transforms/vFor.ts
View file
Open in desktop
Expand Up @@ -60,6 +60,14 @@ export const transformFor = createStructuralDirectiveTransform(
forNode.source
]) as ForRenderListExpression
const memo = findDir(node, 'memo')

if (memo && isTemplateNode(node)) {
memo.exp = processExpression(
memo.exp! as SimpleExpressionNode,
context
)
}

const keyProp = findProp(node, `key`)
const keyExp =
keyProp &&
Expand Down