Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): get refs when using for directives. #5449

Closed
wants to merge 1 commit into from
Closed

fix(runtime-core): get refs when using for directives. #5449

wants to merge 1 commit into from

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Feb 18, 2022 •
edited

fix: #5447

@netlify
Copy link

netlify bot commented Feb 18, 2022 •
edited

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: cef8124

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/620f58508544e100073a5a80

😎 Browse the preview: https://deploy-preview-5449--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Feb 18, 2022 •
edited

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: cef8124

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/620f5850ac06560007e4dafb

😎 Browse the preview: https://deploy-preview-5449--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Feb 18, 2022 •
edited

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: cef8124

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/620f585068ece40008337d48

😎 Browse the preview: https://deploy-preview-5449--vuejs-coverage.netlify.app

@LinusBorg LinusBorg added scope: script-setup ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Feb 18, 2022
@LinusBorg
Copy link
Member

LinusBorg commented Feb 18, 2022 •
edited

suggestion: replace commit message with: "ensure v-for works with template refs in script setup during dev"

That makes for a more descriptive entry in the changelog later.

@ygj6
Copy link
Member Author

ygj6 commented Feb 18, 2022

suggestion: replace commit message with: "ensure v-for works with template refs in script setup during dev"

That makes for a more descriptive entry in the changelog later.

😃 Okay, I will add some testcases later.

@ygj6 ygj6 closed this Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: script-setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cant get ref value in v-for in my project, but work online playground
2 participants
@ygj6 @LinusBorg