Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow opting out from events timestamp check (fix #2513, #3933) #5474

Closed
wants to merge 5 commits into from
Closed

allow opting out from events timestamp check (fix #2513, #3933) #5474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42942fb
fix(runtime-dom): allow opting out from events timestamp check
semiaddict Feb 23, 2022
4d314d1
Merge branch 'main' into fix/allow-opt-out-events-timestamp-check
semiaddict May 10, 2022
a8052a4
Merge branch 'main' into fix/allow-opt-out-events-timestamp-check
semiaddict Sep 2, 2022
46f4574
Merge branch 'main' into fix/allow-opt-out-events-timestamp-check
semiaddict Sep 14, 2022
d19715a
Merge branch 'vuejs:main' into fix/allow-opt-out-events-timestamp-check
semiaddict Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/runtime-core/src/apiCreateApp.ts
View file
Open in desktop
Expand Up @@ -81,6 +81,7 @@ export interface AppConfig {
instance: ComponentPublicInstance | null,
trace: string
) => void
skipEventsTimestampCheck: boolean

/**
* Options to pass to `@vue/compiler-dom`.
Expand Down Expand Up @@ -155,7 +156,8 @@ export function createAppContext(): AppContext {
optionMergeStrategies: {},
errorHandler: undefined,
warnHandler: undefined,
compilerOptions: {}
compilerOptions: {},
skipEventsTimestampCheck: false
},
mixins: [],
components: {},
Expand Down
5 changes: 4 additions & 1 deletion packages/runtime-dom/src/modules/events.ts
View file
Open in desktop
Expand Up @@ -118,7 +118,10 @@ function createInvoker(
// AFTER it was attached.
const timeStamp = e.timeStamp || _getNow()

if (skipTimestampCheck || timeStamp >= invoker.attached - 1) {
// Skip the timestamp check if the skipEventsTimestampCheck app config is set to true.
const appSkipTimestampCheck = instance?.appContext?.config.skipEventsTimestampCheck === true

if (appSkipTimestampCheck || skipTimestampCheck || timeStamp >= invoker.attached - 1) {
callWithAsyncErrorHandling(
patchStopImmediatePropagation(e, invoker.value),
instance,
Expand Down