Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch translate as an attr #5485

Merged
merged 2 commits into from Apr 13, 2022
Merged

fix: patch translate as an attr #5485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab7752f
fix: patch translate as an attr
zhmushan Feb 25, 2022
089b4c7
moveup
zhmushan Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/runtime-dom/__tests__/patchProps.spec.ts
View file
Open in desktop
Expand Up @@ -263,4 +263,11 @@ describe('runtime-dom: props patching', () => {
)
expect(el.value).toBe('baz')
})

test('translate attribute', () => {
const el = document.createElement('div')
patchProp(el, 'translate', null, 'no')
expect(el.translate).toBeFalsy()
expect(el.getAttribute('translate')).toBe('no')
})
})
6 changes: 6 additions & 0 deletions packages/runtime-dom/src/patchProp.ts
View file
Open in desktop
Expand Up @@ -105,6 +105,12 @@ function shouldSetAsProp(
return false
}

// #5462 translate is an enumerated attr, however its
// corresponding DOM property are actually boolean.
if (key === 'translate') {
zhmushan marked this conversation as resolved.
Show resolved Hide resolved
return false
}

// native onclick with string value, must be set as attribute
if (nativeOnRE.test(key) && isString(value)) {
return false
Expand Down