Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): force full diff props for nested component coming from npm. (fix: #5767) #5781

Closed
wants to merge 2 commits into from

Conversation

javastation
Copy link
Contributor

fix #5767
I'm not sure if isHmrUpdating can be used here, so follow the previous logic.

@netlify
Copy link

netlify bot commented Apr 22, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 66084bc
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6262bec711950b0009648cba
😎 Deploy Preview https://deploy-preview-5781--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 66084bc
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/6262bec7fda1ec000ab0b102
😎 Deploy Preview https://deploy-preview-5781--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 66084bc
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6262bec77f7f8c0008da896f
😎 Deploy Preview https://deploy-preview-5781--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lingosandi
Copy link

any news on when this fix would be merged?

@daniloribeiro00
Copy link

@javastation Any news?

keepliving added a commit to keepliving/core that referenced this pull request Aug 4, 2022
@EzeFSpa
Copy link

EzeFSpa commented Sep 10, 2022

Any news with this? we need to see if #5767 is related to this

@antfu antfu added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Oct 10, 2022
@yyx990803
Copy link
Member

This has been fixed by #4077 (>=3.2.38)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR doesn't work for NPM library components that are appended to a slot
7 participants