Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): resolveTemplateUsageCheck skip slot #5963

Closed
wants to merge 1 commit into from

Conversation

zhmushan
Copy link
Contributor

close #5959
Slot node doesn't use the variable from the script, please let me know if I'm missing.

<component>
  <template #default></template>
</component>
<component>
  <template #default="{ data }: Type"></template>
</component>

@netlify
Copy link

netlify bot commented May 20, 2022

👷 Deploy request for vuejs-coverage pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bafdd61

@netlify
Copy link

netlify bot commented May 20, 2022

👷 Deploy request for vue-next-template-explorer pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bafdd61

@netlify
Copy link

netlify bot commented May 20, 2022

👷 Deploy request for vue-sfc-playground pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bafdd61

@yyx990803
Copy link
Member

Thanks, technically even v-slot expressions can contain binding usage with desutrcture:

<comp v-slot="{ x = bar }: Qux"/>

v-for also needs to be special cased. See 583b625

@yyx990803 yyx990803 closed this May 20, 2022
@zhmushan zhmushan deleted the fix_generic_in_slot branch November 11, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using TS generics (Diamond syntax <>) in SFC template fails in 3.2.34
2 participants