fix(shared): LooseRequired typescript 4.7 error #6052 #6112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mioxs
changed the title
❌ Deploy Preview for vuejs-coverage failed.
|
|
I thinks it's better to add some unit tests to avoid further regression. |
|
I have tested |
Justineo
reviewed
Jun 16, 2022
| @@ -5,7 +5,7 @@ export type UnionToIntersection<U> = ( | |||
| : never | |||
|
|
|||
| // make keys required but keep undefined values | |||
| export type LooseRequired<T> = { [P in string & keyof T]: T[P] } | |||
| export type LooseRequired<T> = { [P in keyof T]: T[P] } | |||
There was a problem hiding this comment.
This makes LooseRequired<T> equivalent to T. The original LooseRequired<T> is different because all keys of T are not optional. It is added to match vuejs/rfcs#293.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6052